Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ADC detach bus calibration handle error when not existing. #8932

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Fix ADC detach bus calibration handle error when not existing. #8932

merged 2 commits into from
Nov 29, 2023

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

Added a check if calibration handle of ADC unit exists before deleting it.
Fixes error when reusing analog pin for different peripheral and no there analog pins are used.

Tests scenarios

Tested on ESP32C3.

Related links

@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Peripherals API Relates to peripheral's APIs. label Nov 28, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 3.0.0-Aplha3 milestone Nov 28, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Nov 28, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Nov 29, 2023
@me-no-dev me-no-dev merged commit b01775e into espressif:master Nov 29, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasssvaz lucasssvaz lucasssvaz approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Peripherals API Relates to peripheral's APIs. Status: Pending Merge Pull Request is ready to be merged
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.0-Aplha3
Development

Successfully merging this pull request may close these issues.
3 participants
@P-R-O-C-H-Y @lucasssvaz @me-no-dev