-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for missing Olimex boards #8896
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added board variant for Olimex ESP32-C3-DevKit-Lipo
Added board variant for Olimex ESP32-C6-EVB
Added board variant for Olimex ESP32-S2-DevKit-Lipo-USB
Added board variant for Olimex ESP32-S2-DevKit-Lipo
Added board variant for Olimex ESP32-S3-DevKit-Lipo
Added missing Olimex boards: ESP32-S2-DevKit-Lipo ESP32-S2-DevKit-Lipo-USB ESP32-S3-DevKit-Lipo ESP32-C3-DevKit-Lipo ESP32-C6-EVB Added additional upload speed options to the ESP32-EVB and ESP32-POE(-ISO) boards.
P-R-O-C-H-Y
requested changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Stanimir-Petev PTAL on my comments.
P-R-O-C-H-Y
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Olimex employee here. We were missing few boards from the list and customers requested we add them. Boards added are:
ESP32-S2-DevKit-Lipo
ESP32-S2-DevKit-Lipo-USB
ESP32-S3-DevKit-Lipo
ESP32-C3-DevKit-Lipo
ESP32-C6-EVB
Also added to boards.txt and the respective directories in the "variants" folder. The boards are open-source hardware and info can be found at our website.
We tested as much as we could, but let us know if we missed something.
Thanks espressif and Arduino team.