Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ESP32-S3 PowerFeather #8889

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Add support for ESP32-S3 PowerFeather #8889

merged 4 commits into from
Nov 22, 2023

Conversation

powerfeatherdev
Copy link
Contributor

@powerfeatherdev powerfeatherdev commented Nov 16, 2023

Description of Change

Adds a new variant directory for esp32s3_powerfeather, under which the pins_arduino.h is created.
Entries for esp32s3_powerfeather in boards.txt are added.

Tests scenarios

  • pins_arduino.h is ok
  • boards.txt entries are ok

Related links

Website: https://www.powerfeather.dev/
Allocation for PID under Espressif VID used in this PR: espressif/usb-pids#123

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

@powerfeatherdev powerfeatherdev marked this pull request as draft November 16, 2023 07:10
@powerfeatherdev powerfeatherdev changed the title [WIP] Add initial support for ESP32-S3 PowerFeather Add initial support for ESP32-S3 PowerFeather Nov 16, 2023
@powerfeatherdev
Copy link
Contributor Author

powerfeatherdev commented Nov 16, 2023

Hello @SuGlider, @me-no-dev, @P-R-O-C-H-Y this is my first time adding support for a new board for Arduino (one that I created). I patterned the changes in this PR after other PR's adding support for a new board, and found that they add entries in the boards.txt file and create a variant directory with a pins_arduino.h header inside.

I currently have arduino-esp32 as a component, and so verified that pins_arduino.h works. However, I don't know how to test the entries in the boards.txt locally, as I don't know how to point the Additional Boards Manager URLs to maybe the branch I'm trying to merge in this PR.

Can you point me in the right direction?

boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
@me-no-dev
Copy link
Member

@P-R-O-C-H-Y ptal :)

@powerfeatherdev
Copy link
Contributor Author

Thanks for the guidance @me-no-dev, much appreciated! I've made most of the changes you suggested, ptal.

@powerfeatherdev powerfeatherdev marked this pull request as ready for review November 19, 2023 04:00
@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Nov 21, 2023

Hi @powerfeatherdev, "This branch has conflicts that must be resolved". Can you please fix it? Also merge the latest changes from master into this branch. Thanks

@powerfeatherdev
Copy link
Contributor Author

Hi @P-R-O-C-H-Y, resolved by rebasing to latest master.

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @powerfeatherdev, PTAL on my comments.

variants/esp32s3_powerfeather/pins_arduino.h Outdated Show resolved Hide resolved
variants/esp32s3_powerfeather/pins_arduino.h Show resolved Hide resolved
@powerfeatherdev
Copy link
Contributor Author

Fixed @P-R-O-C-H-Y

@powerfeatherdev powerfeatherdev changed the title Add initial support for ESP32-S3 PowerFeather Add support for ESP32-S3 PowerFeather Nov 22, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Nov 22, 2023
@me-no-dev me-no-dev merged commit a933571 into espressif:master Nov 22, 2023
38 checks passed
@powerfeatherdev
Copy link
Contributor Author

Thank you very much @P-R-O-C-H-Y and @me-no-dev !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants