Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform specific flash speed to magicFlashChipSpeed #8864

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

TD-er
Copy link
Contributor

@TD-er TD-er commented Nov 10, 2023

Description of Change

Various ESP32-variants like the C6, H2, etc. differ in their used flash frequencies.

Also the maximum possible flash size wasn't handled in magicFlashChipSize

Related links

Used the info from esptool.py

Various ESP32-variants like the C6, H2, etc. differ in their used flash frequencies.

Also the maximum possible flash size wasn't handled in `magicFlashChipSize`
@CLAassistant
Copy link

CLAassistant commented Nov 10, 2023

CLA assistant check
All committers have signed the CLA.

@Jason2866 Jason2866 added the 3.0 migration issue relates to migration from 2.X to 3.X version label Nov 10, 2023
@Jason2866 Jason2866 self-assigned this Nov 10, 2023
@Jason2866 Jason2866 self-requested a review November 10, 2023 13:17
@Jason2866
Copy link
Collaborator

Jason2866 commented Nov 10, 2023

@me-no-dev What do you think about adding C2 Arduino support? I have added in our fork and project Tasmota does run stable on the C2.
The needed changes are mostly just additional #ifdefs. The change in this PR is the only specific C2 related one and the changes are also needed for the H2 and the C6.

I will do a PR for the needed C2 changes IF support for the C2 will be added.

@me-no-dev
Copy link
Member

@Jason2866 feel free to add the C2 changes. We do not promise that it will be available through the board manager, but nothing wrong in having it supported "as-component" and even as an option through the lib-builder. Just do not want to add additional megabytes to download for rarely used chip.

@TD-er
Copy link
Contributor Author

TD-er commented Nov 10, 2023

Just curious, why do you think the C2 will only be used rarely?

It looks like it will be a preferred module/chip for those vendors of cheap "smart" devices, like the Sonoff Basic used to be back in the days.
It isn't the best ESP32 variant, but still it is quite capable and you really don't need lots of CPU power for switching simple stuff.

@me-no-dev
Copy link
Member

@TD-er what I mean is that I do not see many development boards popping out and many of our users going for such a limited chip, when C3 and C6 could do so much more for the same money. Just that C2 is a bit too limited for the general public. I agree that specific optimized designs can be achieved and costs can be saved in mass production, just not the home user. That is why we can offer option for those that want to venture, but not load the 99% of the users with additional 100+ MB that they will never need. There is some initiative to split the core into separate chips and have the users install only what they have, but Arduino's platform is not yet supporting everything necessary for that to work. If/when that happens, we will surely add full support for C2 and maybe more future budget chips. Then even things like ESP32-Solo could be supported. I know there are some devices that use it.

@Jason2866
Copy link
Collaborator

Jason2866 commented Nov 11, 2023

@me-no-dev I am perfectly fine with not adding to the boards manager, tbh i don't like it all. But that's not your thing, it is coming from ArduinoIDE. It would be a great step to have all needed C2 changes in source code. So everyone can build the framework with the Arduino Lib Builder (just a few changes there). BTW adding C2 does not add a lot of Mbytes. It is way less than Speech Recognition or Rainmaker does add. Our forked framework with supporting additionally the C2 has 150Mbyte at all (stripped the fat SR and Rainmaker stuff).

Since extracting the C2 parts out of our Arduino fork is "some" work, i can and will only do a PR if it will be merged fast (with the things you mentioned) so that no rebase work needs to be done.

The possibility to split MCUs would be a great improvement! Currently we have to install an full blown extra framework to support the solo1.

@me-no-dev
Copy link
Member

@Jason2866 I don't see a problem to merge C2 support fast, as long as you cover it fast enough here.

@Jason2866 Jason2866 mentioned this pull request Nov 13, 2023
@me-no-dev me-no-dev merged commit 82e5fe8 into espressif:master Nov 13, 2023
37 checks passed
@TD-er TD-er deleted the patch-1 branch November 13, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 migration issue relates to migration from 2.X to 3.X version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants