WiFiClients.setConnectionTimeout added

[JAndrassy]

WiFiClient::setTimeout now shadows Stream::setTimeout which has a different purpose and the unit of the parameter is different. Related issue.

The solution is to rename WiFiClient::setTimeout to Arduino standard WiFiClient::setConnectionTimeout.

EDIT: at the end most of this PR was done in #6676 and #8998

overview of Client API in Arduino networking libraries:
https://github.com/JAndrassy/Arduino-Networking-API/blob/main/ArduinoNetAPILibs.md#client-getters-and-setters

[VojtechBartoska]

Thanks for the PR @JAndrassy.

This relates to #6676.

@P-R-O-C-H-Y PTAL

[JAndrassy]

the difference is that #6676 doesn't define setConnectioniTimeout (the standard name in Arduino networking API)

[github-actions]

Warnings

⚠️

Some issues found for the commit messages in this PR: the commit message "WiFiClients.setConnectionTimeout added": summary looks empty type/action looks empty Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue allowed types are: change,ci,docs,feat,fix,refactor,remove,revert sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello JAndrassy, we appreciate your contribution to this project!

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 45abe3d

[JAndrassy]

after #6676 was merged WiFiClient.setConnectionTimeut now looks here like a new method, but it just the old setTimeout modified (same way this PR does for WiFiClientSecure)

[me-no-dev]

Please revert any changes to WiFiClientSecure. It will inherit those methods from WiFiClient. That was the point of the previous PR that we merged.

[me-no-dev]

@P-R-O-C-H-Y PTAL if this makes sense now :)

[P-R-O-C-H-Y]

@me-no-dev @JAndrassy please take a look on my comment, if it makes sense to you as well.

[JAndrassy]

so at the end it is just a simple setter

[P-R-O-C-H-Y]

Just simple like that :) side question: Arduino API seems to be unit16_t, should we align or better will be to go with uint32_t as @JAndrassy did.
@me-no-dev?

[TD-er]

It isn't unthinkable someone wants to set it to >65 seconds.
Also it doesn't require a reference value, so existing code expecting uint16_t will still compile.

[JAndrassy]

the uint32_t is a leftover from rename from int setTimeout(uint32_t seconds);
_timeout is int
int WiFiClient::connect(IPAddress ip, uint16_t port, int32_t timeout_ms)

[TD-er]

_timeout is int

What would be the interpretation of a negative timeout?