WiFiServer - deprecate available(), use accept() everywhere

[JAndrassy]

In esp8266 and esp32 Arduino WiFi library server.available() was never implemented as documented. It is implemented like server.accept() is documented by Arduino.

server.accept() was an alias for the server.available() from the beginning here in esp32 Arduino platform.

I think with the new major version 3 this should be done. esp8266 Arduino did this change for version 3 too.

[SuGlider]

LGTM - It still is back compatible by keeping the available() as it is, but with a warning for being deprecated.

More information about the argument that @JAndrassy has made:

Based on the documentation from https://www.arduino.cc/reference/en/libraries/wifi/server.available/
The method available() inherits from the Stream utility class. Therefore it should tell how many bytes are ready for reading.

The PR is correct in changing it to accept() which is how it was implemented.
https://www.arduino.cc/reference/en/libraries/ethernet/server.accept/

[SuGlider]

ESP8266 Arduino has done same changes:
https://github.com/esp8266/Arduino/blob/master/libraries/ESP8266WiFi/src/WiFiServer.cpp#L129-L153
https://github.com/esp8266/Arduino/blob/master/libraries/ESP8266WiFi/src/WiFiServer.h#L84-L85

[SuGlider]

Thanks @JAndrassy !!

[mrengineer7777]

Beautiful work. Well done!

[JAndrassy]

@mrengineer7777
it is part of Arduino networking API unification https://github.com/JAndrassy/Arduino-Networking-API/blob/main/ArduinoNetAPILibs.md

[JAndrassy]

@SuGlider

The method available() inherits from the Stream utility class. Therefore it should tell how many bytes are ready for reading.

Server inherits from Print. It doesn't inherit from Stream.
server.available() is for a Server implementation which manages the connected clients. available() then returns first connected client which has data available. It can return the same client repeatedly.

documentation for `server.available()':

Gets a client that is connected to the server and has data available for reading. The connection persists when the returned client object goes out of scope; you can close it by calling client.stop().

My NetApiHelpers library has ArduinoWiFiServer for ESP32. This has correct available() and the print-to-all-clients function to really implement the Print base class. But most users don't need this. accept() is what they really need.