Fixes Rainmaker to be a Managed Component #8842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes is targeted to be used within Arduino Lib Builder and with projects that use Arduino as IDF Component.
Fixes RainMaker in order to use it as Managed Component and with the latest RainMaker release.
SuGlider
added
the
3.0 migration
me-no-dev
reviewed
Nov 8, 2023
|
@me-no-dev - This PR must be merged before fixing the issue in the Lib Builder with sr_models.bin because it adds ESP-SR to the components, which is necessary to run Lib Builder CI correctly in espressif/esp32-arduino-lib-builder#145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR changes
CMakLists.txtandidf_component.ymlto use most possible Managed Components, including RainMaker.It also fixes RainMaker Arduino Layer to be compatible with the latest RainMaker release.
Tests scenarios
It has been tested building the Arduino Lib Builder and also by building a RainMaker example using Arduino as IDF component.
Related links
This shall be merged along with espressif/esp32-arduino-lib-builder#145