Update/upgrade OTAWebUpdater.ino example #8839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtechBartoska
added
Type: Example
me-no-dev
reviewed
Nov 8, 2023
| #include <Ticker.h> | ||
| #include "html.h" | ||
|
|
||
| #define SSID_FORMAT "ESP32-%06X" // 12 chars total |
There was a problem hiding this comment.
#define SSID_FORMAT "ESP32-%06lX"
me-no-dev
reviewed
Nov 8, 2023
| }); | ||
| server.onNotFound([]() {server.send(200, "text/html", indexHtml);}); | ||
| server.begin(); | ||
| Serial.printf("Web Server ready at http://esp32.local or http://%s\n", WiFi.softAPIP().toString()); |
There was a problem hiding this comment.
WiFi.softAPIP().toString().c_str()
me-no-dev
reviewed
Nov 8, 2023
| #ifdef PASSWORD | ||
| snprintf(passwd, 11, PASSWORD); | ||
| #else | ||
| snprintf(passwd, 11, "%s", generatePass(10).c_str()); |
There was a problem hiding this comment.
i'm not sure why the compiler is complaining about truncation, but I suggest you make passwd be 16 bytes long instead.
There was a problem hiding this comment.
The size is actually fairly specific, as it allows you to do a wifi: QR code in a 64 bit square. I'll figure it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamlined a lot of the code
HTML now sends file size
HTML has better progress graphics
HTML redirects back to root after completion
WebServer uses POST and GET to differentiate b/w status
Includes a lot more examples: generate passwords, functionalized setup, ticker, functionalized WebServer response, sending a const file
literal & C-style strings included in a separate header file
Moved to Update library- this does not use ArduinoOTA