Fix ambiguous for TwoWire::requestFrom() methods and align API with Arduino.cc

[safocl]

Description of Change

Remove (comment out) the TwoWire::requestFrom() method overloads.
The compiler says "warning: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second"

Tests scenarios

Example 1
Example 2
Example 3
All compilers report this warning.

Related links

C++17 standard says ([over.match.best]):

If there is exactly one viable function that is a better function than all other viable functions, then it is the one selected by overload resolution; otherwise the call is ill-formed.) [ Example:

void Fcn(const int*,  short);
void Fcn(int*, int);

int i;
short s = 0;

void f() {
  Fcn(&i, s);       // is ambiguous because &i → int* is better than &i → const int*
                    // but s → short is also better than s → int

  Fcn(&i, 1L);      // calls Fcn(int*, int), because &i → int* is better than &i → const int*
                    // and 1L → short and 1L → int are indistinguishable

  Fcn(&i, 'c');     // calls Fcn(int*, int), because &i → int* is better than &i → const int*
                    // and c → int is better than c → short
}
 — end example ]

There is no viable override for these methods that is better - any overrides require equal conversions of different arguments.

upd: this pull request now reflects the accumulated changes for all errors and warnings about ambiguous TwoWire method overloads. It was decided to make a HardwareI2C interface from Arduino.

[CLAassistant]

All committers have signed the CLA.

[safocl]

This is an error, not a warning: g++ requires the -pedantic option to conform to the standard.

[safocl]

I believe that additional method overloads are not the best solution for disambiguating overload resolution. I believe that requests #5764 and #5768 are erroneous. -- That requests are not solve issue arduino-libraries/ArduinoECCX08#25

[VojtechBartoska]

Thanks for the PR, same here please sign CLA.

[safocl]

Thanks for the PR, same here please sign CLA.

Oh yes. I didn’t understand at first that this needed to be done.
I did it.

[github-actions]

	Warnings
⚠️	Some issues found for the commit messages in this PR: the commit message "Fix TwoWire::end() return type.": summary should not end with a period (full stop) summary looks empty type/action looks empty the commit message "Fix TwoWire::setClock() return type.": summary should not end with a period (full stop) summary looks empty type/action looks empty the commit message "Fix ambiguous for TwoWire::requestFrom() methods.": summary should not end with a period (full stop) summary looks empty type/action looks empty the commit message "Fix no return statement in the TwoWire::requestFrom.": summary should not end with a period (full stop) summary looks empty type/action looks empty the commit message "Remove TwoWire::begin(int) overload": body's lines must not be longer than 100 characters summary looks empty type/action looks empty body must have leading blank line the commit message "Rewrite TwoWire with using HardwareI2C": footer must have leading blank line summary looks empty type/action looks empty the commit message "fix(libraries/Wire): fix bad return-statement": scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . the commit message "fix(libraries/Wire): fix return type": summary looks too short scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . the commit message "fix(libraries/Wire): hide slave support elements": scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . body must have leading blank line the commit message "fix(libraries/Wire): restore an accidentally deleted implementation": scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . body must have leading blank line the commit message "refactor(libraries/Wire): add return statement if slave isn't supported": scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . the commit message "refactor(libraries/Wire): fix indentation": summary looks too short scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . the commit message "refactor(libraries/Wire): fix indentation": summary looks too short scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . the commit message "refactor(libraries/Wire): fix indentation": summary looks too short scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . the commit message "refactor(libraries/Wire): remove temporary comment": scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . the commit message "refactor(libraries/Wire): remove unnecessary empty lines": scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . the commit message "refactor(libraries/Wire): remove unused variables": body's lines must not be longer than 100 characters scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . body must have leading blank line the commit message "refactor(libraries/Wire): remove unused variables": body's lines must not be longer than 100 characters scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . body must have leading blank line the commit message "refactor(libraries/Wire): return return types": summary looks too short scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . body must have leading blank line the commit message "refactor(libraries/Wire): use slave without support": scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . body must have leading blank line the commit message "style(libraries/Wire): replace tabs with spaces": scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test] Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
⚠️	Please consider squashing your 27 commits (simplifying branch history).
⚠️	The source branch "TwoWireInheritFromHardwareI2C" incorrect format: contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS). Please rename your branch.

👋 Hello safocl, we appreciate your contribution to this project!

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 311330e

[lucasssvaz]

@safocl Please fix the CI errors

[safocl]

@safocl Please fix the CI errors

I made commits.
Need review for TwoWire::begin(uint8_t address) -- it is should be available without slave
support by SoC?

[lucasssvaz]

I don't think we should remove the error checking from the function return. It is a good way to check if everything inside the method was correctly checked.

The aim of this PR is fixing the ambiguity of the requestFrom methods. I think it is fine to create a HardwareI2C class here but removing the return values should be done in another PR so it can be discussed.

[lucasssvaz]

After discussing with the team we agreed that it is better to keep the return types in the abstract class and the implementation even if differ from the Arduino.cc API.

[safocl]

After discussing with the team we agreed that it is better to keep the return types in the abstract class and the implementation even if differ from the Arduino.cc API.

Do I need to return the return types as they were originally and change them in the abstract class itself?

[me-no-dev]

Yes. change HardwareI2C and revert in Wire

[P-R-O-C-H-Y]

@safocl PTAL

[P-R-O-C-H-Y]

Just small formatting fixes, else looks good.
Tested i2c with OLED, works fine.

[P-R-O-C-H-Y]

Thanks @safocl, great job!