Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UART: Change default Serial1/2 pins and move definition to header #8800

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

lucasssvaz
Copy link
Collaborator

Description of Change

This PR aims to change the default UART1 and UART2 pins to avoid conflicts and improve ease of use.
It also moves the pin definitions to the HardwareSerial.h file so they can be used in sketches.
The final pin assignments are:

Name ESP32 S2 S3 C3 C6 H2
UART0 RX SOC_RX0 3 44 44 20 17 23
UART0 TX SOC_TX0 1 43 43 21 16 24
UART1 RX RX1 26 4 15 18 4 0
UART1 TX TX1 27 5 16 19 5 1
UART2 RX RX2 4 -- 19 -- -- --
UART2 TX TX2 25 -- 20 -- -- --

Tests scenarios

Tested all chips using the (future) UART CI script.

@lucasssvaz lucasssvaz mentioned this pull request Oct 24, 2023
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. LGTM

@me-no-dev
Copy link
Member

this looks good, but brings another task on mind. Have definitions for default pins in another header in the core, so when we add new chips, we have one file to update and we do not forget something.

@lucasssvaz lucasssvaz self-assigned this Oct 24, 2023
@lucasssvaz
Copy link
Collaborator Author

this looks good, but brings another task on mind. Have definitions for default pins in another header in the core, so when we add new chips, we have one file to update and we do not forget something.

Should I do that in this PR ?

@me-no-dev
Copy link
Member

Should I do that in this PR ?

let's make it separate task, since it covers more than Serial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants