Master5.1 s3 gpio48 and platform txt review #8726
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR follows #8600 and #8562 changes for all necessary variant files / boards.txt.
It also fixes the #8560 issue in the Arduino Core 3.0.0
The PR moves common macros and defines to
Arduino.h
, not necessary inpins_arduino.h
file anymore.It also adds NEO_LED macros and constants in order to allow using it in a
digitalWrite()
for Blinking as in the example:https://github.com/espressif/arduino-esp32/blob/master/libraries/ESP32/examples/GPIO/BlinkRGB/BlinkRGB.ino
Tests scenarios
Passed boards CI https://github.com/SuGlider/arduino-esp32/actions/runs/6425347486
Testing compilation of a sketch using the new
Arduino.h
and its changes:Tested the sketch from #8560
Related links
Fix #8560