-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLE upgrades #8724
Merged
Merged
BLE upgrades #8724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lucas Saavedra Vaz <[email protected]>
Closed
lucasssvaz
approved these changes
Oct 6, 2023
This was referenced Jun 16, 2024
reuzurq
added a commit
to reuzurq/Lime_Gen3_IoT_Replacement
that referenced
this pull request
Aug 27, 2024
Update BLE API from A-Emile#16 espressif/arduino-esp32#8724
reuzurq
added a commit
to reuzurq/Lime_Gen3_IoT_Replacement
that referenced
this pull request
Aug 27, 2024
Update BLE API from A-Emile#16 More: espressif/arduino-esp32#8724
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of: #7867
General:
BREAKING CHANGE! Changed API return and parameter type from
std::tring
to Arduino styleString
.Renamed library name from
ESP32 BLE Arduino
to simpleBLE
.Created a new function
getFrame
which returns complete data forBLEAdvertisementData::addData()
.Renamed example files - removed prefix
BLE_
-BLE5_
is left unchanged.Beacon_Scanner
example updated to reflect changes in API - shortened by 28 lines on TLM and URL part.Changed UUID data type from
uint16_t
toBLEUUID
classEddysstone URL:
Created a new constructor which takes as an argument a
BLEAdvertisedDevice
object and initializes URL data from the payload.Created a new function
BLEEddystoneURL::setSmartURL
which encodes the full URL structure.Static frame data no longer needs to be written by the user - they are initialized by the constructor.
Function
BLEEddystoneURL::setPower
now acceptsesp_power_level_t
.Updated
EddystoneURL_Beacon
example to reflect changes in API - shortened by 83 lines.Added comments with explanations to functions
setData
andsetURL
.Tests:
EddystoneURL_Beacon
with the following URLs and read them inBeacon_Scanner
example and using an Android app nRF Connect for Mobile.Eddystone TLM:
Created a new constructor which takes as an argument a
BLEAdvertisedDevice
object and initializes TLM data from the payload.Added comments with explanations to functions
setData
andsetVolt
TODO: test all examples if they are properly working - changes related to the String might have broken something!
Related task: #7841