Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Adafruit metro S3 16MB Flash, 8MB PSRam #8478

Merged
merged 7 commits into from
Aug 29, 2023
Merged

add Adafruit metro S3 16MB Flash, 8MB PSRam #8478

merged 7 commits into from
Aug 29, 2023

Conversation

hathach
Copy link
Contributor

@hathach hathach commented Aug 2, 2023

Description of Change

Tests scenarios

Tested with S3 board with latest arduino-esp32 (2.0.11)

@ladyada

@hathach hathach force-pushed the add-adafruit-metro-s3 branch from ec5cb66 to e8de356 Compare August 2, 2023 05:52
@ladyada
Copy link
Contributor

ladyada commented Aug 2, 2023

verifed on proto hardware - thanks ! :)

@kattni
Copy link
Contributor

kattni commented Aug 17, 2023

@VojtechBartoska Hello! We are close to releasing this board. I wanted to check in with you about getting it added. Please let us know if there's anything else we need to do. Thank you!

@me-no-dev
Copy link
Member

this will be merged prior to releasing 2.0.12 (probably next week or so)

@VojtechBartoska VojtechBartoska added this to the 2.0.12 milestone Aug 22, 2023
@VojtechBartoska
Copy link
Contributor

added to 2.0.12, @ladyada 2.0.12 is supposed to be last bug fix release based on IDF 4.4. We'll after that focus just on 3.0 (IDF 5.1), please consider this for adding new boards support.

@ladyada
Copy link
Contributor

ladyada commented Aug 22, 2023

sounds great - we're also moving to 5.1 for circuitpython :)
having fun with the RGB TFT driving ability of the S3
image

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Aug 23, 2023
@hathach
Copy link
Contributor Author

hathach commented Aug 23, 2023

hihi, we want to make some last minute changes (minor) for this board. Please hold on a bit before merging. thank you :)

@P-R-O-C-H-Y P-R-O-C-H-Y removed the Status: Pending Merge Pull Request is ready to be merged label Aug 23, 2023
@P-R-O-C-H-Y
Copy link
Member

@hathach ping me when its ready please :)

@hathach
Copy link
Contributor Author

hathach commented Aug 23, 2023

@hathach ping me when its ready please :)

@P-R-O-C-H-Y thank you for waiting, just pushed the latest update, this is ready to merge now.

P-R-O-C-H-Y
P-R-O-C-H-Y reviewed Aug 23, 2023
View reviewed changes
boards.txt Outdated Show resolved Hide resolved
P-R-O-C-H-Y
P-R-O-C-H-Y reviewed Aug 23, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hathach please take a look on my comment :)

@hathach
Copy link
Contributor Author

hathach commented Aug 23, 2023 •
edited
Loading

@hathach please take a look on my comment :)

thank you very much for your review, I just follow your suggestion to remove psram_type of qspi. However, since I don't actually have this board yet. Could you mind waiting a bit longer for @ladyada to test on her prototypes.

@ladyada
Copy link
Contributor

ladyada commented Aug 23, 2023

thanks for the update, just tested and i get 8MB psram so this can be merged :)

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Aug 24, 2023
@me-no-dev me-no-dev merged commit dbc060b into espressif:master Aug 29, 2023
@hathach hathach deleted the add-adafruit-metro-s3 branch September 5, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.12
Development

Successfully merging this pull request may close these issues.
6 participants
@hathach @ladyada @kattni @me-no-dev @VojtechBartoska @P-R-O-C-H-Y