Bluetooth-classic: release BLE memory when BT classic only is requested #8051
Conversation
…E_BR_EDR_ONLY is set BLE memory can be released if bluetooth-classic - only is requested
cores/esp32/esp32-hal-bt.c
Outdated
| #define BT_MODE ESP_BT_MODE_CLASSIC_BT | ||
| #elif defined(CONFIG_BTDM_CONTROLLER_MODE_BTDM) | ||
| #define BT_MODE ESP_BT_MODE_BTDM |
There was a problem hiding this comment.
does switching defines do anything here?
There was a problem hiding this comment.
My intention is to tell btStart() that I want to use bluetooth-classic only. CONFIG_BTDM_CONTROLLER_MODE_BTDM is defined in a default aduino-esp32 configuration, so it is the first #if that matches and can not be overridden. When we switch the defines BR_EDR_ONLY can be forced with a -DCONFIG_BTDM_CONTROLLER_MODE_BR_EDR_ONLY.
If you prefer an other #define like ARDUINO_BLUETOOTH_EDR_ONLY or a new function for BT-classic initialization please let me know.
There was a problem hiding this comment.
how about you instead -DBT_MODE=ESP_BT_MODE_CLASSIC_BT yourself and only #ifndef BT_MODE do the config check.
cores/esp32/esp32-hal-bt.c
Outdated
| @@ -34,16 +34,28 @@ bool btStarted(){ | |||
|
|
|||
| bool btStart(){ | |||
| esp_bt_controller_config_t cfg = BT_CONTROLLER_INIT_CONFIG_DEFAULT(); | |||
| #if CONFIG_IDF_TARGET_ESP32 | |||
| #ifdef CONFIG_BTDM_CONTROLLER_MODE_BR_EDR_ONLY | |||
There was a problem hiding this comment.
This would need to check #if BT_MODE == ESP_BT_MODE_CLASSIC_BT instead
cores/esp32/esp32-hal-bt.c
Outdated
| #elif BT_MODE == ESP_BT_MODE_BLE | ||
| esp_bt_controller_mem_release(ESP_BT_MODE_CLASSIC_BT); | ||
| #endif | ||
| cfg.mode=BT_MODE; |
There was a problem hiding this comment.
cfg.mode is only available on ESP32. You should have kept the whole block filtered for ESP32 target. Also as far as I remember, doing mem release of the classic BT will also break BLE. If BT/BLE is not used, that memory is already cleared when Arduino is starting up. So keep just esp_bt_controller_mem_release(ESP_BT_MODE_BLE);
There was a problem hiding this comment.
sorry, you were too fast.
- esp_bt_controller_mem_release(ESP_BT_MODE_CLASSIC_BT) crashes the esp32 without an error message when using BLE
- unexpectedly #if BT_MODE == ESP_BT_MODE_CLASSIC_BT doesn't work. The preprocessor only likes integer values, I will find a solution. Thinking of:
cfg.mode=BT_MODE;
if(cfg.mode == ESP_BT_MODE_CLASSIC_BT) {
esp_bt_controller_mem_release(ESP_BT_MODE_BLE);
}
tomorrow....
There was a problem hiding this comment.
#if CONFIG_IDF_TARGET_ESP32
cfg.mode=BT_MODE;
if(cfg.mode == ESP_BT_MODE_CLASSIC_BT) {
esp_bt_controller_mem_release(ESP_BT_MODE_BLE);
}
#endifLooks like a good plan 👍
There was a problem hiding this comment.
@me-no-dev Is it not possible to clear memory used by BT_CLASSIC if I'm using only BLE? In the case of Rainmaker, we often run into low memory since both Classic BT and BLE are on during WiFi provisioning. Tagging @shahpiyushv.
There was a problem hiding this comment.
@sanketwadekar as far as I remember and it seems that @ferbar confirms it above, it is not possible to release classic memory even if you are using just BLE
VojtechBartoska
added
the
Resolution: Awaiting response
|
@me-no-dev Can you please check? Updates are there, thanks @ferbar. |
|
If you are fine with my changes I would squash them before the PR merge. |
me-no-dev
added
Status: Pending Merge
|
|
|
@me-no-dev do you need any additional information? |
Checklist
Description of Change
If CONFIG_BTDM_CONTROLLER_MODE_BR_EDR_ONLY is defined BLE is disabled, therefore the allocated memory can get freed to save about 14kB ram.
Tests scenarios
Arduino-esp32:2,0.6 (current master) with ESP32 under platformio with and without -DCONFIG_BTDM_CONTROLLER_MODE_BR_EDR_ONLY=y
Related links
#6451