Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing upload.flags on boards.txt #5589

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Add missing upload.flags on boards.txt #5589

merged 1 commit into from
Aug 25, 2021

Conversation

riosnav
Copy link
Contributor

@riosnav riosnav commented Aug 24, 2021

Summary

Fixes #5572.

There were several boards that were missing the upload.flags and upload.extra_flags fields, resulting in an error during upload of a sketch.

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pedrominatel pedrominatel added the Type: Bug 🐛 All bugs label Aug 24, 2021
@me-no-dev
Copy link
Member

thanks @riosnav for going through the file :)

@me-no-dev me-no-dev merged commit a62979d into espressif:master Aug 25, 2021
@riosnav riosnav deleted the patch-1 branch August 25, 2021 21:51
@thebear132 thebear132 mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug 🐛 All bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload fails for Sparkfun ESP32 Thing Plus {upload.flags}
4 participants
@riosnav @CLAassistant @me-no-dev @pedrominatel