-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0.5] Update Heltec ESP32 series boards definition #4577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Heltec-Aaron-Lee
commented
Nov 25, 2020
- Added LoRaWAN features option for Heltec ESP32 + LoRa series boards;
- Added a new board Heltec Wireless Stick Lite.
me-no-dev
reviewed
Dec 1, 2020
me-no-dev
reviewed
Dec 1, 2020
me-no-dev
changed the title
Update Heltec ESP32 series boards definition
[1.0.5] Update Heltec ESP32 series boards definition
Dec 1, 2020
Hi @me-no-dev Thank you for your hints, I had fixed the PR request, please confirm again. |
me-no-dev
reviewed
Dec 2, 2020
me-no-dev
reviewed
Dec 2, 2020
me-no-dev
reviewed
Dec 2, 2020
me-no-dev
reviewed
Dec 2, 2020
me-no-dev
reviewed
Dec 2, 2020
Almost there :) sorry I missed the deleted definitions earlier |
Hi @me-no-dev Thank you for your fast response, just updated. 😃 |
@Heltec-Aaron-Lee waiting for CI to complete and will merge :) |
👍 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.