Provisioning Fixes #4522
Merged
Provisioning Fixes #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweetymhaiske
force-pushed
the
Provision_Fixes
branch
from
3cc0099 to
703995e
Compare
me-no-dev
reviewed
Nov 12, 2020
| @@ -45,8 +45,11 @@ void setup() { | |||
| /* uint8_t uuid[16] = {0xb4, 0xdf, 0x5a, 0x1c, 0x3f, 0x6b, 0xf4, 0xbf, | |||
| 0xea, 0x4a, 0x82, 0x03, 0x04, 0x90, 0x1a, 0x02 };*/ | |||
| WiFi.onEvent(SysProvEvent); | |||
| //WiFi.beginProvision(WIFI_PROV_SCHEME_BLE, WIFI_PROV_SCHEME_BLE_EVENT_HANDLER_FREE_BTDM, WIFI_PROV_SECURITY_1, "abcd1234"); | |||
| WiFi.beginProvision(WIFI_PROV_SCHEME_SOFTAP, WIFI_PROV_SCHEME_HANDLER_NONE, WIFI_PROV_SECURITY_1, "abcd1234"); | |||
| #if CONFIG_IDF_TARGET_ESP32 | |||
There was a problem hiding this comment.
add check if bluedroid is enabled also.
me-no-dev
reviewed
Nov 12, 2020
libraries/WiFi/src/WiFiProv.h
Outdated
| @@ -19,6 +19,9 @@ | |||
|
|
|||
| #include "WiFi.h" | |||
| #include "wifi_provisioning/manager.h" | |||
| #if CONFIG_IDF_TARGET_ESP32 | |||
| #include "SimpleBLE.h" | |||
There was a problem hiding this comment.
why does it need to be in the header?
sweetymhaiske
force-pushed
the
Provision_Fixes
branch
from
703995e to
af09d39
Compare
sweetymhaiske
force-pushed
the
Provision_Fixes
branch
from
af09d39 to
789fb63
Compare
me-no-dev
pushed a commit
that referenced
this pull request
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.