Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix F_Fat::format return false when succeed #3220

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Fix F_Fat::format return false when succeed #3220

merged 1 commit into from
Sep 20, 2019

Conversation

luc-github
Copy link
Contributor

this is due to usage of esp_err_t result; instead of boolean, ESP_OK = 0, so it is false

Fix F_Fat::format return false when succeed
3b3da3f 
this is due to ussage of esp_err_t result; instead of boolean, ESP_OK =0 so it is false
@me-no-dev
Copy link
Member

@lbernstone want to have a look?

@lbernstone
Copy link
Contributor

Looks good to me.

@luc-github
Copy link
Contributor Author

@lbernstone thank you ^_^

@me-no-dev me-no-dev merged commit 56fe2db into espressif:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luc-github @me-no-dev @lbernstone