Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a look at this line of code
Observe that
HTTP_MAX_SEND_WAIT
expands to 5000 (here)Review the definition of setTimeout in WiFiClient class which subsequently passes the value to the Client class as follows
Solution is to divide it by 1000 in the call to setTimeout. Alternative solution would be to re-define the
HTTP_MAX_SEND_WAIT
to be defined in seconds instead of milliseconds, but that would be different from the surrounding defines, which is why I opted for the proposed implementation. The compiler should shake out the maths anyway.