Hide log_v behind conditional define, reduce excessive logging #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cyberman54 from espressif#2250 recommended reducing unnecessary logging.
|
do people use verbose a lot? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cyberman54 from #2250 recommended reducing unnecessary logging. There have not been any reported problems with i2c and cpu frequency changes since it was implemented in the 1.0.1 release. This pr hides these verbose log reported behind the
ENABLE_I2C_DEBUG_BUFFERdefine. They will be available if necessary, but normally will not be included in compiled code.Chuck.