Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(board): Add custom board Huidu HD-WF2/HD-WF4 - esp32-s3 HUB75 driver boards #10779

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

vortigont
Copy link
Contributor

@vortigont vortigont commented Dec 24, 2024

Huidu HD-WF2 - esp32-s3 HUB75 driver board
Chip: esp32-s3
Flash: 8MiB
RTC: BM8563
Vendor: https://www.hdwell.com/Product/index46.html

IOs:

  • 2xHUB75 ports
  • button
  • status LED
  • USB-A

Huidu HD-WF4 - esp32-s3 HUB75 driver board
Chip: esp32-s3
Flash: 8MiB
RTC: BM8563
Vendor: https://www.hdwell.com/Product/index46.html

IOs:

  • 4xHUB75 ports
  • button
  • status LED
  • USB-A
  • P/S IO ports

Copy link
Contributor

github-actions bot commented Dec 24, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello vortigont, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 7d3c11d

@vortigont vortigont force-pushed the board_huidu branch 5 times, most recently from d2a544d to bafd58e Compare January 6, 2025 06:22
@vortigont vortigont changed the title feat(board): Add custom board Huidu HD-WF2 - esp32-s3 HUB75 driver board feat(board): Add custom board Huidu HD-WF2/HD-WF4 - esp32-s3 HUB75 driver boards Jan 6, 2025
@P-R-O-C-H-Y
Copy link
Member

Hi @vortigont, please place those new boards at the end of the boards.txt file as they are the first boards from this manufacturer. Thanks

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Awaiting Response awaiting a response from the author label Jan 6, 2025
@vortigont vortigont force-pushed the board_huidu branch 2 times, most recently from f150e98 to b074763 Compare January 6, 2025 14:13
@vortigont
Copy link
Contributor Author

done!

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL, just a small change needed.

boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Awaiting Response awaiting a response from the author labels Jan 7, 2025
@me-no-dev me-no-dev merged commit e305a48 into espressif:master Jan 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants