Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Zigbee): Recall bounded devices after reboot + IEEE address option for commands #10676

Open
wants to merge 1 commit into
base: release/v3.1.x
Choose a base branch
from

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR adds new feature/fix to recall bounded devices from the binding table after device reboot, with that also the isBound() will return correct value, as the devices will be found if there were some before rebooting.

  • mirror updates on Switch/ColorDimSwitch, so there is now option to send the command also to the endpoint num + ieee (long address) combination.

Tests scenarios

Tested locally

Related links

Closes #10646

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Dec 3, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Libraries Issue is related to Library support. label Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Warnings
⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 97643ec

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Test Results

 61 files   61 suites   5m 47s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
143 runs  143 ✅ 0 💤 0 ❌

Results for commit 97643ec.

♻️ This comment has been updated with latest results.

@P-R-O-C-H-Y P-R-O-C-H-Y force-pushed the feat/zigbee-recall-binding-table branch from 78c6725 to 97643ec Compare December 3, 2024 21:42
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C60‼️ +18K0.00‼️ +3.450⚠️ +16960.00‼️ +5.71
ESP32H20‼️ +15K0.00‼️ +2.690⚠️ +15960.00‼️ +5.50
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C6ESP32H2
ExampleFLASHRAMFLASHRAM
Zigbee/examples/Zigbee_Color_Dimmable_Light‼️ +18K⚠️ +1680‼️ +15K⚠️ +1580
Zigbee/examples/Zigbee_Color_Dimmer_Switch‼️ +10K⚠️ +936‼️ +7K⚠️ +860
Zigbee/examples/Zigbee_On_Off_Light‼️ +18K⚠️ +1696‼️ +14K⚠️ +1596
Zigbee/examples/Zigbee_On_Off_Switch‼️ +11K⚠️ +920‼️ +7K⚠️ +860
Zigbee/examples/Zigbee_Scan_Networks‼️ +14K⚠️ +1260‼️ +10K⚠️ +1128
Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy‼️ +16K⚠️ +972‼️ +12K⚠️ +832
Zigbee/examples/Zigbee_Temperature_Sensor‼️ +13K⚠️ +944‼️ +9K⚠️ +836
Zigbee/examples/Zigbee_Thermostat‼️ +12K⚠️ +608‼️ +9K⚠️ +540

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Review needed Issue or PR is awaiting review label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Libraries Issue is related to Library support. Status: Review needed Issue or PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant