Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Zigbee): Add missing direction to report commands [3.0.X] #10625

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR fixes Zigbee reporting command which is missing direction attribute.

Tests scenarios

Related links

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Nov 19, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y changed the base branch from master to release/v3.0.x November 19, 2024 12:37
Copy link
Contributor

github-actions bot commented Nov 19, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix(Zigbee): Add missing direction to report commands":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 3d3d765

@P-R-O-C-H-Y P-R-O-C-H-Y changed the title Fix/zigbee reporting direction backport to 3.0.X fix(Zigbee): Add missing direction to report commands [3.0.X] Nov 19, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 3.0.8 milestone Nov 19, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Libraries Issue is related to Library support. label Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

Test Results

 56 files   56 suites   4m 16s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
134 runs  134 ✅ 0 💤 0 ❌

Results for commit 3d3d765.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C6💚 -10K0💚 -2.000.00💚 -308⚠️ +12💚 -0.93⚠️ +0.04
ESP32H2💚 -11K0💚 -2.130.00💚 -3360💚 -1.040.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C6ESP32H2
ExampleFLASHRAMFLASHRAM
Zigbee/examples/Zigbee_Color_Dimmable_Light💚 -10K💚 -12💚 -11K💚 -40
Zigbee/examples/Zigbee_Color_Dimmer_Switch💚 -2K⚠️ +12💚 -3K💚 -32
Zigbee/examples/Zigbee_On_Off_Light💚 -10K⚠️ +4💚 -11K💚 -40
Zigbee/examples/Zigbee_On_Off_Switch💚 -2012💚 -4💚 -3K💚 -32
Zigbee/examples/Zigbee_Scan_Networks💚 -392💚 -4💚 -1430💚 -32
Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy💚 -10K⚠️ +4💚 -11K💚 -40
Zigbee/examples/Zigbee_Temperature_Sensor💚 -402⚠️ +12💚 -1462💚 -32
Zigbee/examples/Zigbee_Thermostat💚 -292💚 -308💚 -1348💚 -336

@lucasssvaz lucasssvaz force-pushed the fix/zigbee-reporting-direction-backport branch from d7fbb8b to a3c3153 Compare November 19, 2024 15:22
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Nov 20, 2024
@me-no-dev me-no-dev merged commit 74e6f0f into espressif:release/v3.0.x Nov 20, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Libraries Issue is related to Library support. Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants