Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FreeRTOS Symbols in OThreadCLI #10412

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Update FreeRTOS Symbols in OThreadCLI #10412

merged 3 commits into from
Oct 3, 2024

Conversation

SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Oct 2, 2024

Description of Change

TARGET: 3.0.x and 3.1.x

Fixes FreeRTOS types.
This affects certain ways of building applications using IDF Components.

Tests scenarios

CI only.

Related links

@SuGlider SuGlider self-assigned this Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update OThreadCLI.cpp":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 78a3ca5

QueueHandle_t instead of xQueueHandle
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C6ESP32H2
ExampleFLASHRAMFLASHRAM
OpenThread/examples/COAP/coap_lamp0000
OpenThread/examples/COAP/coap_switch0000
OpenThread/examples/SimpleCLI0000
OpenThread/examples/SimpleNode0000
OpenThread/examples/SimpleThreadNetwork/ExtendedRouterNode0000
OpenThread/examples/SimpleThreadNetwork/LeaderNode0000
OpenThread/examples/SimpleThreadNetwork/RouterNode0000
OpenThread/examples/ThreadScan0000
OpenThread/examples/onReceive0000

@SuGlider SuGlider added this to the 3.0.5 milestone Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Test Results

 41 files   41 suites   3m 12s ⏱️
 19 tests  19 ✅ 0 💤 0 ❌
120 runs  120 ✅ 0 💤 0 ❌

Results for commit 78a3ca5.

♻️ This comment has been updated with latest results.

@lucasssvaz lucasssvaz added Area: Libraries Issue is related to Library support. Status: Pending Merge Pull Request is ready to be merged labels Oct 3, 2024
@me-no-dev me-no-dev merged commit 733373a into master Oct 3, 2024
64 checks passed
@me-no-dev me-no-dev deleted the freertos_symbols branch October 3, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Libraries Issue is related to Library support. Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

3 participants