Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arduino): rain maker common version #10338

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

SuGlider
Copy link
Collaborator

Description of Change

Fixes Arduino Managed Components declaration when building Arduino as IDF component using Windows 11 + IDF 5.1.4.

Error Message:

Dependencies lock doesn't exist, solving dependencies.
CMake Error at C:/Espressif/frameworks/esp-idf-v5.1.4/tools/cmake/build.cmake:540 (message):
  WARNING: From https://github.com/espressif/arduino-esp32

   * [new ref]             refs/pull/10335/head  -> refs/pull/10335/head
   * [new ref]             refs/pull/10335/merge -> refs/pull/10335/merge



  ERROR: Because espressif/arduino-esp32
  (4e9eb35752a36bd4e03739dc7e1c3ac246c49d3c) depends on
  espressif/rmaker_common (^1.4.3) which doesn't match any versions,
  espressif/arduino-esp32 is forbidden.

  So, because project depends on espressif/arduino-esp32
  (4e9eb35752a36bd4e03739dc7e1c3ac246c49d3c), version solving failed.

Call Stack (most recent call first):
  C:/Espressif/frameworks/esp-idf-v5.1.4/tools/cmake/project.cmake:604 (idf_build_process)
  CMakeLists.txt:11 (project)


....................................................-- Configuring incomplete, errors occurred!

Tests scenarios

Using Windows 11 and building a "hello world" sketch using Arduino as IDF Component.

Related links

none

Fixes Arduino components for Windows 11 with IDF 5.1.4 when building Arduino as IDF component.
@SuGlider SuGlider added the Area: Arduino as ESP-IDF component Issues about Arduino used as component in ESP-IDF label Sep 12, 2024
@SuGlider SuGlider added this to the 3.0.5 milestone Sep 12, 2024
@SuGlider SuGlider self-assigned this Sep 12, 2024
Copy link
Contributor

github-actions bot commented Sep 12, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 2f45300

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Sep 13, 2024
@me-no-dev me-no-dev merged commit ac0de43 into master Sep 13, 2024
29 of 30 checks passed
@me-no-dev me-no-dev deleted the idf_component_yml_win11 branch September 13, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Arduino as ESP-IDF component Issues about Arduino used as component in ESP-IDF Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

3 participants