Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events): Fix crash in getStdFunctionAddress #10321

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

me-no-dev
Copy link
Member

Fixes: #10316

Copy link
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 46be999

Copy link
Contributor

github-actions bot commented Sep 10, 2024

Test Results

 56 files   -  83   56 suites   - 83   4m 22s ⏱️ - 1h 38m 6s
 21 tests  -   9   21 ✅  -   9  0 💤 ±0  0 ❌ ±0 
135 runs   - 168  135 ✅  - 168  0 💤 ±0  0 ❌ ±0 

Results for commit 46be999. ± Comparison against base commit cbe0f2f.

This pull request removes 9 tests.
performance.coremark.test_coremark ‑ test_coremark
performance.fibonacci.test_fibonacci ‑ test_fibonacci
performance.psramspeed.test_psramspeed ‑ test_psramspeed
performance.ramspeed.test_ramspeed ‑ test_ramspeed
performance.superpi.test_superpi ‑ test_superpi
test_touch_errors
test_touch_interrtupt
test_touch_read
validation.periman.test_periman ‑ test_periman

♻️ This comment has been updated with latest results.

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3💚 -12⚠️ +40.000.00000.000.00
ESP32S2💚 -4⚠️ +40.000.00000.000.00
ESP32C30⚠️ +120.000.00000.000.00
ESP32C60⚠️ +120.000.00000.000.00
ESP32H20⚠️ +120.000.00000.000.00
ESP32💚 -4⚠️ +40.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Ethernet/examples/ETH_W5500_Arduino_SPI0000⚠️ +100⚠️ +100⚠️ +100⚠️ +40
Ethernet/examples/ETH_W5500_IDF_SPI0000⚠️ +100⚠️ +100⚠️ +10000
Ethernet/examples/ETH_WIFI_BRIDGE⚠️ +40⚠️ +40⚠️ +100⚠️ +100--00
NetworkClientSecure/examples/WiFiClientInsecure💚 -40💚 -400000--💚 -40
NetworkClientSecure/examples/WiFiClientPSK💚 -40💚 -400000--💚 -40
NetworkClientSecure/examples/WiFiClientSecure💚 -40💚 -400000--💚 -40
NetworkClientSecure/examples/WiFiClientSecureEnterprise💚 -40💚 -400000--💚 -40
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade💚 -40💚 -400000--💚 -40
NetworkClientSecure/examples/WiFiClientShowPeerCredentials💚 -40💚 -400000--💚 -40
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse💚 -40💚 -400000--💚 -40
PPP/examples/PPP_Basic0000⚠️ +120⚠️ +120⚠️ +12000
PPP/examples/PPP_WIFI_BRIDGE00⚠️ +40⚠️ +100⚠️ +120--00
WebServer/examples/AdvancedWebServer💚 -40💚 -400000--💚 -40
WebServer/examples/FSBrowser💚 -40💚 -400000--💚 -40
WebServer/examples/Filters💚 -40💚 -400000--💚 -40
WebServer/examples/HelloServer💚 -40💚 -400000--💚 -40
WebServer/examples/HttpAdvancedAuth💚 -40💚 -400000--💚 -40
WebServer/examples/HttpAuthCallback💚 -40💚 -400000--💚 -40
WebServer/examples/HttpAuthCallbackInline💚 -40💚 -400000--💚 -40
WebServer/examples/HttpBasicAuth💚 -40💚 -400000--💚 -40
WebServer/examples/HttpBasicAuthSHA1💚 -40⚠️ +400000--💚 -40
WebServer/examples/HttpBasicAuthSHA1orBearerToken💚 -40💚 -400000--💚 -40
WebServer/examples/MultiHomedServers💚 -40💚 -400000--💚 -40
WebServer/examples/PathArgServer💚 -40💚 -400000--💚 -40
WebServer/examples/SDWebServer💚 -40💚 -400000--💚 -40
WebServer/examples/SimpleAuthentification💚 -40💚 -400000--💚 -40
WebServer/examples/UploadHugeFile💚 -40💚 -400000--💚 -40
WebServer/examples/WebServer💚 -40💚 -400000--💚 -40
WebServer/examples/WebUpdate💚 -40💚 -400000--💚 -40
WiFi/examples/FTM/FTM_Initiator💚 -40💚 -400000--💚 -40
WiFi/examples/FTM/FTM_Responder💚 -40💚 -400000--💚 -40
WiFi/examples/SimpleWiFiServer💚 -40💚 -400000--💚 -40
WiFi/examples/WPS💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiAccessPoint💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiBlueToothSwitch💚 -120--0000--💚 -40
WiFi/examples/WiFiClient💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiClientBasic💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiClientConnect💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiClientEnterprise💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiClientEvents💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiClientStaticIP💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiExtender💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiIPv6💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiMulti💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiMultiAdvanced💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiScan💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiScanAsync💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiScanDualAntenna💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiScanTime💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiSmartConfig💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiTelnetToSerial💚 -40💚 -400000--💚 -40
WiFi/examples/WiFiUDPClient💚 -40💚 -400000--💚 -40
Ethernet/examples/ETH_LAN8720----------00
Ethernet/examples/ETH_TLK110----------00

@VojtechBartoska VojtechBartoska added the Area: WiFi Issue related to WiFi label Sep 10, 2024
@SuGlider SuGlider added the Status: Pending Merge Pull Request is ready to be merged label Sep 12, 2024
@me-no-dev me-no-dev merged commit eda6d21 into master Sep 13, 2024
82 checks passed
@me-no-dev me-no-dev deleted the bugfix/get_std_fn_addr branch September 13, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: WiFi Issue related to WiFi Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetworkEvents: NetworkEvents::removeEvent crashes when multiple event handlers are present
4 participants