Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CodeCell ESP32C3 new 3rd part board #10177

Merged
merged 7 commits into from
Aug 16, 2024
Merged

Adding CodeCell ESP32C3 new 3rd part board #10177

merged 7 commits into from
Aug 16, 2024

Conversation

microbotsio
Copy link
Contributor

Adding CodeCell ESP32C3 new 3rd part board with updating boards.txt and adding the pins_arduino.h in the variant/CodeCell folder.

@microbotsio
Add CodeCell ESP32C3 variant folder
989453d 
feat(variants): Add CodeCell ESP32C3 variant folder

Added the `codecell` folder to the `arduino-esp32/variants` directory to support the CodeCell ESP32C3 board. This folder includes the necessary pin mappings and configuration files.
@microbotsio
Update boards.txt for CodeCell ESP32C3
d84ae95 
chore(board): Update boards.txt for CodeCell ESP32C3

Updated the boards.txt configuration to include settings specific to the CodeCell ESP32C3 board, such as upload speed and partition schemes.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 16, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add CodeCell ESP32C3 variant folder":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Add codecell ESP32C3 variant folder":
    • summary looks empty
    • type/action looks empty
  • the commit message "Delete variants/CodeCell directory":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update boards.txt for CodeCell ESP32C3":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Update pins_arduino.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update variants/CodeCell/pins_arduino.h":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
⚠️ Please consider squashing your 7 commits (simplifying branch history).

👋 Hello microbotsio, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 631470f

P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@microbotsio PTAL

variants/CodeCell/pins_arduino.h Outdated Show resolved Hide resolved
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microbotsio
Copy link
Contributor Author

Can you explain why it the boards test and failed to merge?

P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@microbotsio

boards.txt Show resolved Hide resolved
@microbotsio
Delete variants/CodeCell directory
a3bb035
@microbotsio
Add codecell ESP32C3 variant folder
2c2f1e9 
feat(variants): Add codecell ESP32C3 variant folder

Added the CodeCell ESP32C3 variant folder to support the CodeCell ESP32C3 board.
This folder contains the necessary pin mappings and configuration files.
@microbotsio
Update pins_arduino.h
aae75fe
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Aug 16, 2024
@microbotsio
Copy link
Contributor Author

Is there anything else we need to do from our side?

@P-R-O-C-H-Y
Copy link
Member

Is there anything else we need to do from our side?

@microbotsio All good from your side, the PR ready to be merged (marked as pending merge). We will merge it soon :)

@microbotsio
Copy link
Contributor Author

great thanks!

@me-no-dev me-no-dev merged commit 49a3c10 into espressif:master Aug 16, 2024
9 checks passed
@microbotsio
Copy link
Contributor Author

Could you please let me know when the next 3.0.5 release is scheduled? :)

We like our board to show up in Board Manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@microbotsio @P-R-O-C-H-Y @me-no-dev