fix(USB): OTG S2 and S3 debug print #10123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESP32-S2 and S3 using USB CDC OTG (TinyUSB) won't print any log information. This commit fixes that.
SuGlider
added
Chip: ESP32-S2
👋 Hello SuGlider, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
|
@VojtechBartoska - Please add the 3.0.5 TAG / Milestone. |
Test Results 56 files - 83 56 suites - 83 4m 49s ⏱️ - 1h 38m 15s Results for commit b92a134. ± Comparison against base commit 70786dc. This pull request removes 9 tests.♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Tested the PR with S2 and the problem still occurs |
I have a different result. What are the IDE settings that you have used? |
|
I'm puzzled.... I use the same, but within Windows and it works. Do you see any output or nothing at all?
|
|
@lucasssvaz - Please use the new sketch from the desciption for your testing. This is the output I get from the USB Serial Port: |
|
@SuGlider The LED is working properly in the sketch. |
|
The S2 has 2 different USB serial ports when using TinyUSB. One for uploading and a different one for when TinyUSB driver is activated. For instance with Windows, I see COM12 and after reseting the board I see the COM17. Does the S2 also create 2 "/dev/usb" files on Mac? |
|
USB logging using the S2 was working within the Arduino Core 2.0.14 using almost the same code. Could you check it under MacOS and let me know? |
I see only 1 port after connecting the board(USB-port) to PC. |
@SuGlider Just tested on 2.0.14 with ESP32S2 and it works correctly using your sketch (just had to remove print info). EDIT: Tested latest 2.X branch, also works fine. |
|
To be sure tested again on master with exactly same code + same Tools menu settings. |
changed Macro testing
P-R-O-C-H-Y
approved these changes
Aug 8, 2024
lucasssvaz
approved these changes
Aug 8, 2024
lucasssvaz
added
Status: Pending Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
ESP32-S2 and S3 using USB CDC OTG (TinyUSB) won't print any log information. This commit fixes that.
Tests scenarios
Using ESP32-S2 and S3 with
USB CDC On Bootenabled and in the case of S3, USB Mode shall beUSB OTG (TinyUSB).Set log level to Verbose.
Related links
Fixes #10121