Skip to content

Commit

Permalink
Fix missing virtual declarations in Stream.h (#10348)
Browse files Browse the repository at this point in the history
* Fix missing virtual declarations in Stream.h

Fixes some changes made in PR #10328

* Remove the virtual destructor as Print class has one

As pointed out by @JAndrassy
  • Loading branch information
TD-er authored Sep 17, 2024
1 parent 2f89026 commit e989445
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cores/esp32/Stream.h
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ class Stream : public Print {
float parseFloat(LookaheadMode lookahead = SKIP_ALL, char ignore = NO_IGNORE_CHAR);
// float version of parseInt

size_t readBytes(char *buffer, size_t length); // read chars from stream into buffer
size_t readBytes(uint8_t *buffer, size_t length) {
virtual size_t readBytes(char *buffer, size_t length); // read chars from stream into buffer
virtual size_t readBytes(uint8_t *buffer, size_t length) {
return readBytes((char *)buffer, length);
}
// terminates if length characters have been read or timeout (see setTimeout)
Expand All @@ -120,7 +120,7 @@ class Stream : public Print {
// returns the number of characters placed in the buffer (0 means no valid data found)

// Arduino String functions to be added here
String readString();
virtual String readString();
String readStringUntil(char terminator);

protected:
Expand Down

0 comments on commit e989445

Please sign in to comment.