upgrade to v2 #96
Merged
upgrade to v2 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add convert_map and new get_encoder function.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
- add support for branchformer/e-branchformer - add developers guide - modified readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why upgrade to version 2?
ESPnet currently supports the onnx-convertible
make_pad_maskfunction.With this change, we can export new ESPnet models without the help of espnet_onnx.
However, we still need to re-implement some modules to make it onnx-convertible, such as RNNEncoder.
So, in the next version, espnet_onnx will check if modules need replacing to make handling a new model easier with minimal effort.