Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Haoyang (+ Martin): Typings update #42

Merged
merged 8 commits into from
Feb 1, 2016
Merged

Conversation

fongandrew
Copy link
Member

Per DefinitelyTyped/tsd#269, TSD has officially been deprecated in favor of https://github.com/typings/typings.

This PR switches everything from TSD over to Typings. You'll need to run make clean and make setup again.

The biggest differences between TSD and Typings are:

  • Some Javascript libraries installed via NPM may function differently depending on whether they're used in a browser context or a Node.js server context. Typings supports different definitions for each environment, so references to definitions should be to the versions inside the typings/browser folder, rather than the typings/main folder. For the sake of simplifying things, I've changed most of the type references to typings/browser.d.ts (which contains all of the references) rather than enumerate them individually.
  • TSD installs all definition dependencies in ambient (global) context, whereas Typings permits definitions to require other definitions in a non-ambient form. That can be useful if, for instance, a library uses the new ES6 import / export syntax for Javascript modules or if we want to bundle two different versions of a library with different type definitions. At the moment though, the only impact on us is that our definitions are stored in the typings/browser/ambient directory.

haoyang pushed a commit that referenced this pull request Feb 1, 2016
@haoyang haoyang merged commit a0f9bba into master Feb 1, 2016
@haoyang haoyang deleted the af/dependencies-update branch February 1, 2016 23:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants