-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EspSoftwareSerial 8.0.1: onReceive bug fix and new namespace #8869
Conversation
a2921f7
to
c89dac8
Compare
In order to be able to move forward with the development of this lib, like implementing issue resolutions for strapping pins usage as serial pins, the code is refactored to use the namespace SoftwareSerial, and rename the class SoftwareSerial to UART. |
As previously stated, I'd be very wary with simply dropping stuff without providing any backwards compatibility. Suppose we have Same goes with config; (claiming SoftwareSerial for namespace feels weird tbh) |
@mcspr You kind of mostly told me what I was hoping to hear :-) I've added the using to map class |
Any name should be fine, just not the old class one. We'd wanna a patch release approach here for most identifiers, 3.2.0 come you can remove those if you want. |
I haven't explicitly tried now, but I suspect the parity would need the same. So I've reverted to |
…their own GPIO capabilities definitions.
I bumped up the bug fix release number just to make sure that Platformio doesn't keep using the wrong commit for 8.0.0 - it scans the main branch instead of looking at Github release tags. I like the Arduino library manager better :-) |
…#8869) * Upcoming EspSoftwareSerial 7.0.1 * EspSoftwareSerial example: higher bitrates due to forcing half-duplex * Adapt to SoftwareSerial's latest use of namespace. * In EspSoftwareSerial, some renaming after review feedback. * EspSoftwareSerial's use of a template class in order to permit users their own GPIO capabilities definitions. * CI caught some warning. * Stick to non-namespace EspSoftwareSerial class name for the moment. * Delegate operator() is now nullptr-safe, good for use in ISRs. * Pushed EspSoftwareSerial 8.0.1: Platformio picks up versions that aren't published in Github
Fixed onReceive IRAM cache issues.
Example for power-saving with wakeup from suspend by SW serial RX event.