Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postmortem improvements #8839

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Conversation

mhightower83
Copy link
Contributor

Improve divide by 0 reporting to point back at the divide function caller

Improve stack offset adjustments to be independent of __wrap_system_restart_local()'s stack frame size.

Improve divide by 0 reporting to point back at the divide function caller

Improve stack offset adjustments to be independent of
`__wrap_system_restart_local()`'s  stack frame size.
Copy link
Collaborator

@mcspr mcspr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm based on repeating crashes from #8670

cores/esp8266/core_esp8266_postmortem.cpp Outdated Show resolved Hide resolved
cores/esp8266/core_esp8266_postmortem.cpp Show resolved Hide resolved
@mcspr mcspr merged commit 326be35 into esp8266:master Feb 1, 2023
@mcspr mcspr added this to the 3.1.2 milestone Feb 1, 2023
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
* divide by 0 reporting to point back at the divide function caller
* stack offset adjustments to be independent of __wrap_system_restart_local()'s stack frame size.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants