Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use -g++ or -gcc suffixes in command line arguments #8829

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Jan 26, 2023

It may confuse some greedy parsers matching compiler either with a glob or by iterating each argument and not stopping on the first one

ref. this library used by VSCode Arduino extension
https://github.com/elektronikworkshop/cocopa/blob/ce125785574735b777e2a40bad0e85dd41580692/src/ParserGcc.ts#L63-L68

fix #8809

It may confuse some greedy parsers matching compiler either with a glob
or by iterating each argument and not stopping on the first one

ref. this library used by VSCode Arduino extension
* https://github.com/elektronikworkshop/cocopa/blob/ce125785574735b777e2a40bad0e85dd41580692/src/ParserGcc.ts#L63-L68

fix esp8266#8809
@mcspr mcspr added this to the 3.1.2 milestone Jan 26, 2023
@mcspr mcspr merged commit 79dde21 into esp8266:master Jan 26, 2023
@mcspr mcspr deleted the not-compiler branch January 26, 2023 11:20
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
It may confuse some greedy parsers matching compiler either with a glob
or by iterating each argument and not stopping on the first one

ref. this library used by VSCode Arduino extension
https://github.com/elektronikworkshop/cocopa/blob/ce125785574735b777e2a40bad0e85dd41580692/src/ParserGcc.ts#L63-L68

fix esp8266#8809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant