Add eraseCredentials option to WiFi disconnect method. #8758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-a-v
reviewed
Dec 14, 2022
d-a-v
approved these changes
Dec 14, 2022
|
Do you know why its failing? Is it missing header? |
d-a-v
reviewed
Dec 14, 2022
|
Shame on me, will fix today. Didnt see that 😀
|
d-a-v
reviewed
Dec 14, 2022
…ap to meaningful name 'eraseCredentials'. Fix comments.
d-a-v
approved these changes
Dec 15, 2022
mcspr
changed the title
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
Add eraseCredentials option to WiFi disconnect method (legacy default: true)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that WiFi.disconnect function always set SSID and Password to NULL. On ESP32's version of Arduino, user can define if the config should be ever touched or not. When manually implementing reconnection, current state requires to store credentials externally between disconnect and connect method calls.
This PR aims to fix this problem by introducing second variable (eraseap), which defaults to false to maintain compatibility.