-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hostname management #8626
Fix hostname management #8626
Conversation
Running the example from Matrix, everything works correctly. Is the idea to allow to set netif->hostname later on, or it will stay global hostname setting? |
Both are possible, I think keeping a common global name is better.
This is an interesting idea. For now I believe a sketch using the arduino API won't link these functions in.
Which matrix is it ? |
Capital M one! Where you said it would be enough to check ./libraries/ESP8266WiFi/examples/IPv6/IPv6.ino example 🤷
True, but it's the same issue as with dhcps funcs - NONOS SDK api stops working / interferes with the existing code. SDK part could also be |
* manage hostname with sdk string
This proposal addresses two issues
For both issue, solution is to play with hostname location in ram, reserved by SDK, and filled with
ESP-baffed
when WiFi boots but which can be now overwritten back when user had already set it to something.fixes #8143