StreamConstPtr: disallow passing a String temporary #8410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(warning: deleting object of abstract class type 'Stream' which has non-virtual destructor will cause undefined behavior [-Wdelete-non-virtual-dtor])
mcspr
approved these changes
Dec 15, 2021
There was a problem hiding this comment.
This no longer works
StreamConstPtr test{String("test")}; // String is destroyed next line, can't access it's contents
StreamConstPtr test{"test"}; // implicitly creating String{"test"}, same lifetime as aboveThis was allowed, but no longer is
StreamConstPtr{"test"}.available(); // ...since we are technically in the same 'expression', still and StreamConstPtr itself is a temporary?| @@ -61,6 +61,7 @@ class Stream: public Print { | |||
| virtual int peek() = 0; | |||
|
|
|||
| Stream() {} | |||
| virtual ~Stream() {} | |||
There was a problem hiding this comment.
commitlog added in OP
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
* StreamConstPtr: prevent from passing a temporary String instance * unconditionally allow progmem chars * missing virtual destructor in Stream (warning: deleting object of abstract class type 'Stream' which has non-virtual destructor will cause undefined behavior [-Wdelete-non-virtual-dtor])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless using it like this:
using
auto var = StreamConstPtr(String-Temporary)leads to errors because it stores an expected-to-be invalid pointer.This PR prevents from using temporary
StringwithStreamConstPtr.(note :
StreamConstPtr("test").sendAll(elsewhere)is implicitely using an intermediateString)edit:
+ missing virtual destructor in
Stream::