Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEAmDNS Fixes 1.1 #5619

Merged
merged 4 commits into from
Jan 18, 2019
Merged

LEAmDNS Fixes 1.1 #5619

merged 4 commits into from
Jan 18, 2019

Conversation

LaborEtArs
Copy link
Contributor

Third try...

  • Better separation of ESP wifi thread code from user thread code
  • Added a flag for 'update()'-less use (disabled by default)
  • The too fast updates for service queries are fixed
  • Switched fully to PolledTimeout; LEATimeFlag not needed anymore (BTW: a const 'expired()' method would be helpful)
  • The device should stay visible now even after the first TTL timeout
  • Improved service querying (queries five times now)
  • Fixed default TTLs (bug introduced in Fixes 1.0)

- Better separation of ESP wifi thread code from user thread code
- Added a flag for 'update()'-less use (disabled by default)
- The too fast updates for service queries are fixed
- Switched fully to PolledTimeout; LEATimeFlag not needed anymore (BTW: a const 'expired()' method would be helpful)
- The device should stay visible now even after the first TTL timeout
- Improved service querying (queries five times now)
@devyte
Copy link
Collaborator

devyte commented Jan 14, 2019

@LaborEtArs there seems to be something missing here, the build is failing due to a compile error related to a timeflag.

This was referenced Jan 15, 2019
@LaborEtArs
Copy link
Contributor Author

All references to LEATimeFlag should have been removed (teanslated to PolledTimeout)... will have a look into the sources again

@LaborEtArs
Copy link
Contributor Author

Sorry, can’t find a reference to LEATimeFlag in the sources anymore, which file is causing the build problems?

@d-a-v
Copy link
Collaborator

d-a-v commented Jan 15, 2019

Checks Have Failed > details > click on one red result > scroll down

/home/travis/build/esp8266/Arduino/libraries/ESP8266mDNS/examples/LEAmDNS/mDNS_Clock/mDNS_Clock.ino:320:10: error: 'clsMDNSTimeFlag' does not name a type
   static clsMDNSTimeFlag timeFlag(UPDATE_CYCLE);
          ^
/home/travis/build/esp8266/Arduino/libraries/ESP8266mDNS/examples/LEAmDNS/mDNS_Clock/mDNS_Clock.ino:321:7: error: 'timeFlag' was not declared in this scope
   if (timeFlag.flagged()/*ulNextTimeUpdate < millis()*/) {
       ^

@LaborEtArs
Copy link
Contributor Author

The examples... arghhh

LaborEtArs added 2 commits January 15, 2019 18:45
Removed references to LEATimeFlag.h
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devyte devyte merged commit 570b9a6 into esp8266:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants