Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for Adafruit Feather HUZZAH ESP8266 #4083

Closed
wants to merge 7 commits into from

Conversation

nrobinson2000
Copy link

@nrobinson2000 nrobinson2000 commented Jan 3, 2018

Adafruit Feather HUZZAH ESP8266 (ESP-12S)

The Adafruit Feather HUZZAH ESP8266 is an Arduino-compatible Wi-Fi development board powered by Ai-Thinker's ESP-12S, clocked at 80 MHz at 3.3V logic. A SiLabs CP2104 USB-Serial chip is included so that you can upload code at 921600 baud for fast development time. It also has auto-reset so no noodling with pins and reset button pressings. A 3.7V Lithium polymer battery connector is included, making it ideal for portable projects. The Adafruit Feather HUZZAH ESP8266 will automatically recharge a connected battery when USB power is available.

Product page: https://www.adafruit.com/product/2821

Copy link
Contributor

@yoursunny yoursunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text seems correct. This was my first ESP8266 board.

@d-a-v d-a-v mentioned this pull request Jan 4, 2018
@nrobinson2000
Copy link
Author

Is there any reason why this hasn’t been merged yet?

@igrr
Copy link
Member

igrr commented Jan 9, 2018

Can we please keep it easy on "high-quality", "blistering", and so on? Otherwise LGTM, good addition.

@nrobinson2000
Copy link
Author

nrobinson2000 commented Jan 9, 2018

I adapted this text from the product page, and Adafruit tends to use that kind of diction when describing its own products. I’ll remove those words.

@d-a-v
Copy link
Collaborator

d-a-v commented Jan 9, 2018

@nrobinson. Your yesterday's text is now in tools/boards.txt.py, try

./tools/boards.txt.py --doc

@igrr in the generator PR I only pushed boards.txt, not the rest so It can be double checked.
For instance with this Huzzah PR, what needs now to be done is:

./tools/boards.txt.py --docgen

and (double check then) commit the newly generated doc/boards.rst.

If there is any modification to make, it should be done in ./tools/boards.txt.py first.
Then both could be commited together I guess.

@d-a-v d-a-v self-assigned this Jan 9, 2018
@d-a-v
Copy link
Collaborator

d-a-v commented Jan 15, 2018

@nrobinson2000 your changes are merged (link).
Blistering is still there, and the generator is open for fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants