Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lwIP-v2 ready to use #3783

Merged
merged 3 commits into from
Nov 3, 2017
Merged

lwIP-v2 ready to use #3783

merged 3 commits into from
Nov 3, 2017

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Nov 1, 2017

boards.txt comes from #3722
lwIP sources are cloned from their origin, currently v2.0.3stable

@devyte
Copy link
Collaborator

devyte commented Nov 2, 2017

I'm now very confused with all the lwips flying around. Is there any way to extract the version info from the lib? Something like a #define, or version string, or git commit, or whatever, that can get printed out? I don't trust what I'm building or linking against anymore.

@davisonja
Copy link

Worst case md5 is simple

@d-a-v d-a-v mentioned this pull request Nov 2, 2017
@d-a-v
Copy link
Collaborator Author

d-a-v commented Nov 2, 2017

#ifndef LWIP_HASH_STR
#define LWIP_HASH_STR "esp1.4"
#endif
printf("lwIP-%d.%d.%d(%s)",
        LWIP_VERSION_MAJOR, 
        LWIP_VERSION_MINOR,
        LWIP_VERSION_REVISION,
        LWIP_HASH_STR);

LWIP_HASH_STR is not defined with lwip1.4

With lwip2, it says: lwIP-2.0.3(92f23d6(tag:STABLE-2_0_3_RELEASE)).
The hash number is the lwip commit ref, with the tag if there's one.

The two previous PR are now closed.

@d-a-v
Copy link
Collaborator Author

d-a-v commented Nov 2, 2017

@devyte @davisonja LWIP_VERSION_MAJOR is accessible in sketch with #include "lwip/init.h".
It was already the case with lwip1.4. What do you think should be further done about that ?
@igrr @devyte @davisonja are you OK with the included boards.txt ?
I have only tested Generic/nodemcu(ESP01), wemos D1R1, D1-mini and D1-mini-lite(with esp8285).

@igrr
Copy link
Member

igrr commented Nov 2, 2017

boards.txt looks good, but i'll check with nodemcu. Will report back.

@igrr igrr merged commit 7315095 into esp8266:master Nov 3, 2017
@devyte
Copy link
Collaborator

devyte commented Nov 3, 2017

Be aware that the ESPAsync libs don't seem to build with lwip2.
@me-no-dev at first glance, the changes needed seem minimal, but I didn't go through them in detail.

@d-a-v
Copy link
Collaborator Author

d-a-v commented Nov 3, 2017

@me-no-dev changes probably will be similar as #3129.

@d-a-v d-a-v deleted the lwip2v3 branch November 3, 2017 08:26
@me-no-dev
Copy link
Collaborator

on it :)

@devyte
Copy link
Collaborator

devyte commented Nov 4, 2017

@me-no-dev ESPAsyncTCP builds now. Will you also update ESPAsyncUDP? That would allow me to build my application and start testing :)

@devyte
Copy link
Collaborator

devyte commented Nov 4, 2017

ESP8266LLMNR lib doesn't seem to build due to differences in UdpContext signatures

@reaper7
Copy link
Contributor

reaper7 commented Nov 6, 2017

@devyte - ESPAsyncUDP also updated, works for me with LWIPv2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants