Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArduinoOTA optimizations #2445

Merged
merged 1 commit into from
Aug 27, 2016
Merged

ArduinoOTA optimizations #2445

merged 1 commit into from
Aug 27, 2016

Conversation

me-no-dev
Copy link
Collaborator

  • Added option to control if the ESP should be rebooted on success
  • Added delay before ESP.restart() is called
  • Added some comments to the header

ArduinoOTA optimizations
7a321dc 
- Added option to control if the ESP should be rebooted on success
- Added delay before ESP.restart() is called
- Added some comments to the header
@igrr
Copy link
Member

igrr commented Aug 27, 2016

Looks good to me

@me-no-dev
Copy link
Collaborator Author

I have the feeling that not delaying before the reboot is the root cause of many OTA errors received.

@igrr
Copy link
Member

igrr commented Aug 27, 2016

True. Just noticed i had delay(100); added before ESP.restart in my local tree :)

@codecov-io
Copy link

codecov-io commented Aug 27, 2016 •
edited
Loading

Current coverage is 27.80% (diff: 100%)

Merging #2445 into master will not change coverage

@@             master      #2445   diff @@
==========================================
  Files            20         20          
  Lines          3625       3625          
  Methods         335        335          
  Messages          0          0          
  Branches        656        656          
==========================================
  Hits           1008       1008          
  Misses         2441       2441          
  Partials        176        176

Powered by Codecov. Last update b412660...7a321dc

@me-no-dev me-no-dev merged commit 889775c into esp8266:master Aug 27, 2016
@me-no-dev me-no-dev mentioned this pull request Aug 27, 2016
Closed
@me-no-dev me-no-dev deleted the arduino-ota branch August 31, 2016 18:33
@earlephilhower earlephilhower mentioned this pull request Jan 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@me-no-dev @igrr @codecov-io