-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for Alexa Bug #4235
Comments
The referenced code rings a bell in my mind. There might already be a PR with the proposal, but I don't think Alexa was mentioned. |
seems u r right, but that pr is a lil bit diffrent. i dont know which is better. |
The PR for esp8266#4235 This esp8266#4151 is the same issue, but with a diffrent solution.
@reloxx13 @Monarch73 please discuss the differences between this PR and #4151 . |
Its independent from Alexa, but works for her, too. As Monach said, it fixes the missing args if the server send the "application/x-www-form-urlencoded" header content-type instead of "application/json" and plain text (json) and not as suggestest for form-urlencoded a key/value pair. i think monarches is better, cuz he made it in the _parseArguments method, while the one i posted is out of that method. |
I would prefer my solution as it saves code, because the code for adding the plain content is already existing. |
good point 👍 |
I don't mind how it's done. Either way is fine with me. |
I am struggling with every byte to keep ota firmware update via web interface running ;-) |
I think if you do a direct size-comparison of the binaries, you wouldn't get any differences. The optimizer in gcc picks up these kind of things pretty well... how ever, like I said, I don't mind how it's done |
In that case I don't mind how it is done either. |
Can this work with Google home? |
any news about the PR ? :S |
Right now we're in a half-frozen state for 2.4.1, finishing up only critical stability issues and waiting on the imminent sdk 2.2. I'll revisit this after 2.4.1 is out the door. |
I've got the same problem: I want to control some electrical gimmicks via Hue-V1-Protocol saying "alexa test 50%". I can get "Content-Length" but no content! In my opinion the best soolution would be a body-method. |
Fixed with #5252 . |
Heya,
this library is used by the Tasmota Firmware to emulate HUE and WEMO Devices to control them with Amazon Alexa.
Currently their seems to be a bug in the Alexa Firmware where the header content is wrong resulting in a wrong parsing and missing args.
Another dev @OFreddy made a workaround for it.
Please check this out and tell us, if their is any chance to include it in your library, since we cannot do anything in the Alexa Firmware.
arendst/Tasmota#1639 (comment)
arendst/Tasmota#1434
The text was updated successfully, but these errors were encountered: