Fix reuse for different URIs in HTTPClient::begin (#8466)

esp8266 · Mar 30, 2022 · 32939c4 · 32939c4
1 parent 06e3c56
commit 32939c4
Showing 1 changed file with 17 additions and 1 deletion.
diff --git a/libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.cpp b/libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.cpp
@@ -102,9 +102,16 @@ bool HTTPClient::begin(WiFiClient &client, const String& url) {
  */
 bool HTTPClient::begin(WiFiClient &client, const String& host, uint16_t port, const String& uri, bool https)
 {
+    // Disconnect when reusing HTTPClient to talk to a different host
+    if (!_host.isEmpty() && _host != host) {
+        _canReuse = false;
+        disconnect(true);
+    }
+
     _client = client.clone();
 
-     clear();
+    clear();
+
     _host = host;
     _port = port;
     _uri = uri;
@@ -155,6 +162,8 @@ bool HTTPClient::beginInternal(const String& __url, const char* expectedProtocol
         _base64Authorization = base64::encode(auth, false /* doNewLines */);
     }
 
+    const String oldHost = _host;
+
     // get port
     index = host.indexOf(':');
     if(index >= 0) {
@@ -164,6 +173,13 @@ bool HTTPClient::beginInternal(const String& __url, const char* expectedProtocol
     } else {
         _host = host;
     }
+
+    // Disconnect when reusing HTTPClient to talk to a different host
+    if (!oldHost.isEmpty() && _host != oldHost) {
+        _canReuse = false;
+        disconnect(true);
+    }
+
     _uri = url;
 
     if ( expectedProtocol != nullptr && _protocol != expectedProtocol) {