This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Remove --bin option from cargo-espmonitor
#60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wasn't there prior to the clap-ification, and it gets overwritten anyway, which could confuse people. I don't love that this duplicates the contents of AppArgs in CargoAppArgs, but oh well, what are you gonna do... (I do recognize that cargo-espmonitor maybe should have a --bin option in order to select the bin target for projects that have more than one. But I'll revisit that later.)
kelnos
force-pushed
the
remove-cargo-bin-option
branch
from
010996a to
4783b82
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't there prior to the clap-ification, and it gets overwritten anyway, which could confuse people.
I don't love that this duplicates the contents of
AppArgsinCargoAppArgs, but oh well, what are you gonna do...(I do recognize that cargo-espmonitor maybe should have a
--binoption in order to select the bin target for projects that have more than one. But I'll revisit that later.)