Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow set_power_saving even for coex #3081

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jan 31, 2025

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

I think there was a good reason not to allow any other PS than Min for COEX before but it turns out it's fine to set it at least to None and in the case of ESP32-C6 it's almost unusable with any other PS

I changed some (two) examples to set PowerSavingMode::None - could be applied to more / all examples.

We could also now turn coex into a config-option (since it doesn't change the API surface anymore)

This should be the solution for #3049 on ESP32-C6 but unfortunately doesn't help with ESP32 (so not closing it via this)

Testing

Run the wifi_coex example

Sorry, something went wrong.

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @bugadani regarding the migration guide, but otherwise LGTM

@bjoernQ bjoernQ added this pull request to the merge queue Feb 3, 2025
Merged via the queue into esp-rs:main with commit 9a34d0e Feb 3, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants