-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esp-wifi: Late enable BT interrupts #2981
esp-wifi: Late enable BT interrupts #2981
Conversation
I guess this is fine, but instead of moving the implementation, wouldn't moving the call to |
I created #2982 to address this and more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to block this PR, but I'm just a bit concerned as we have made some changes around this area before. I'd feel a bit better if the flow of execution was a bit more clear, as it stands right now I'm unsure where/when certain interrupts are enabled within the init process. I think we can make it a bit clearer, but I don't have ideas of the top of my head for now.
I'll approve this as is, but if you have any ideas to make it clearer feel free to implement, or maybe make an issue so we can come back to it later.
Maybe we can expand on this in #2982 - I'd like this bug to be fixed in the first place asap |
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
Fixes #2883
For whatever reason when using Serial-JTAG it triggered a BT interrupt which made the interrupt fire before we had a callback which handled it correctly.
Additionally using the published
edge-*
crates now - DHCP is working again in the example.skip-changelog
because of the changeCargo.toml
inexamples
Testing
Manual testing of the examples