Fix LEDC duty-cycle updates #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… order for the new duty-cycle to take effect
|
Checked on all targets Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #285.
Added
start_duty_without_fade!()andupdate_channel!()toset_duty!()in order for the new duty-cycle to take effect.start_duty_without_fade!()is a new macro that configures the fading register. It was found that settingLEDC_DUTY_START_CHnis required in order for the new duty-cycle to take effect. The other fields of theconf1are also written and configured for no fading.For
cfg(esp32)theupdate_channel!()macro now takes a speed argument, and will result in a no-op for high speed. Because high speed variant doesn't have thepara_upfield.This PR also removes the restriction that
set_duty(0)could not be called without error.Tested on ESP32C3. Builds for ESP32.