Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Uart::read_bytes blocking #2935

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Make Uart::read_bytes blocking #2935

merged 2 commits into from
Jan 13, 2025
+194 −78

Conversation

bugadani
Copy link
Contributor

Hopefully this is right, errors and expectations around them are tricky when one doesn't get enough sleep.

@bugadani bugadani force-pushed the uart-read branch 4 times, most recently from d5cb9c4 to 3283f35 Compare January 13, 2025 08:13
@bugadani bugadani marked this pull request as ready for review January 13, 2025 08:24
SergioGasquez
SergioGasquez approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the idea of having read_bytes blocking and read_buffered_bytes

@SergioGasquez SergioGasquez mentioned this pull request Jan 13, 2025
Merged
6 tasks
bjoernQ
bjoernQ approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessebraham jessebraham enabled auto-merge January 13, 2025 14:32
@jessebraham jessebraham added this pull request to the merge queue Jan 13, 2025
Merged via the queue into esp-rs:main with commit 8c48c74 Jan 13, 2025
28 checks passed
@bugadani bugadani deleted the uart-read branch January 13, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bugadani @bjoernQ @SergioGasquez @jessebraham