This repository has been archived by the owner on May 23, 2024. It is now read-only.
Add Custom halt feature #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failures are probably not related to this PR? |
|
CI failures are caused by a new Clippy lint - I think we should just ignore it like we do in Just add this: https://github.com/esp-rs/esp-hal/blob/68628fc0086934c67d34156f3cc45aca81bf99d0/esp-hal/Cargo.toml#L223-L224 Thanks! |
t-moe
force-pushed
the
feature/custom-halt
branch
from
c2cc0fc
to
3f0aed2
Compare
bjoernQ
reviewed
May 15, 2024
bjoernQ
approved these changes
May 15, 2024
t-moe
force-pushed
the
feature/custom-halt
branch
from
3f0aed2
to
5c62c8f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows me to implement esp-rs/esp-hal#1586 or do custom stuff like flushing logs etc...
I know that for using esp-backtrace in an production environment, we probably want to refactor/extend in a different direction, but at least this allows for hacking stuff during development without duplicating and adapting the entire panic handler.