New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix anyhow::Ok function shadowing Result::Ok #27

Merged

N3xed merged 1 commit into esp-rs:master from Hecatron-Forks:anyhow-fixes

Nov 28, 2021

Contributor

Hecatron commented Nov 27, 2021

It doesn't look as if anyhow is willing to change they're code.
dtolnay/anyhow#201

This time around I've changed the anyhow imports so they're not using wildcards.
I've checked this with rustfmt and the CI action this time around.


          anyhow fixes

a004c6b

N3xed approved these changes

View reviewed changes

Collaborator

N3xed left a comment

LGTM, thanks for the fix.

N3xed changed the title ~~anyhow fixes~~ Fix anyhow::Ok function shadowing Result::Ok

N3xed linked an issue

that may be closed by this pull request

ldproxy doesn't build under windows #25

Closed

N3xed merged commit 31eeac8 into esp-rs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet